Fixed param name typo #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicosKaralis
commented
Mar 9, 2023
| @@ -489,7 +489,7 @@ class SVGIcons2SVGFontStream extends Transform { | |||
| glyphPath.getBounds(); | |||
| if (this._options.centerHorizontally) { | |||
| glyphPath.translate( | |||
| (glyph.width - (bounds.maxX - bounds.minX)) / 2 - bounds.minX | |||
There was a problem hiding this comment.
I'm not 100% on this
To me this solved my issues with misaligned glyphs but it's best if someone that understands this better gives some feedback
nfroidure
added a commit
that referenced
this pull request
Nov 7, 2024
CLI arg are all camelized. Also fixed the docs issues revealed by #167. BREAKING CHANGE: CLI usages will need an update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo setting horizontal center, the way it is it will never even attempt to center the glyph
This should be enough to fix it